Skip to content

Reviews

Author: Shibin Das (d34dman)Last updated

In review

Reviewers: open, join #3627995 on drupal.org

The concept is written for every reader. These briefs are not: each one is for the people who know one part of Drupal well, and asks them only what we can't answer without them.

Each brief has the same shape:

  1. Why this reaches your area: what the module builds on or changes there.
  2. Questions for you: the decisions we need help with, each linked to the part of the concept it affects.
  3. What we built: the exact files and behaviour, so you can check our claims.
  4. See it: screenshots, and what to try in the demo site.
  5. Read only these sections: the parts of the concept that matter for your area.
  6. What we heard: filled in as answers come in, with what changed because of them.

The briefs

Planning and progress across all briefs: #3627995.

Area Brief Discussion
Design Tokens API and UI Suite Tokens #3627977
Single-Directory Components, patterns, JavaScript Components and patterns #3627978
Admin theme (Default Admin; Claro, Gin) Admin theme #3627979
UX, usability and Navigation UX and Navigation #3627981
CSS CSS #3627983
Media Library Media Library #3627984
Accessibility Accessibility #3627986

How to respond

  • Comment in the brief's issue. Short answers are fine: "B, because …" helps as much as a long review. Reviewers get issue credit.
  • Propose changes to a brief (a question that's wrong, a claim that's inaccurate) with a merge request from the issue fork. Briefs live in docs/reviews/ of the module repository.
  • Disagree with the concept itself? Say so in the issue. Settled answers become decisions and change the concept; the brief's "What we heard" section links to the change.

The demo site

Every brief points at the same demo: a Drupal 11.5.0-beta1 site with the module, its adapters and the Media Library pilot, plus demo content (articles with images, an Arabic translation for RTL).

git clone https://github.com/d34dman/design_system_api_demo.git
cd design_system_api_demo
ddev start
ddev install-demo        # prints a one-time login link

Useful commands once it runs:

Command What it does
ddev admin-theme default_admin / claro Switch the admin theme
ddev frontend-theme olivero / stark Switch the frontend theme
ddev drush pmu design_system_api_media_library Turn the Media Library pilot off (the "before")
ddev drush ds:tokens --theme=olivero Every token, its value and the layer it came from
ddev drush ds:resolve media-card.border --theme=olivero --mode=dark One value and its provenance
ddev ds-brand on Turn on an author's brand values for Olivero
ddev ds-lint Run the CSS linter on the pilot and on a file with seeded mistakes

The Media Library opens from the image field of any article's edit form (/node/1/edit; RTL at /ar/node/1/edit). Author values can be edited at Appearance » Design system.

The demo also builds a proof gallery: 4 themes × 5 contexts (light, dark, RTL, more contrast, forced colors) × pilot off and on, with an axe-core scan of each. The screenshots in the briefs come from it.