2024-10-08 (10 commits)

Overview

Fixes for a couple of interesting big_pipe and jsonapi problems. Documentation improvements, type hints improvements, and less deprecations pending to be addressed related to PHPUnint.

Changes

It covers commits from 2024-10-08 on 11.x branch.

#3083507: Standardize “plugin ID” in doc comments instead of “plugin_id”

#3083507 - 4e9a602833e80ebcb6ac195f25403c55e1283c9b

Unify the way to refer to plugin identifiers over documentation blocks.

#3473203: Fix use of ConstraintViolation instead of ConstraintViolationInterface in CKEditor5 tests

#3473203 - ce398e869385e35fd14f85e5c4a4276fe780e724

Use ConstraintViolationInterface instead of ConstraintViolation to better follow the actually returned values in ckeditor5 module tests.

#3477329: Recipe validation should always treat required modules as installed

#3477329 - 81f055eb1cabb12c36f99c96675b1b9991d2d168

Makes recipe validation around installed modules a bit less strict for greater flexibility.

#3474731: Method getMockForAbstractClass() is deprecated - replace in class EntityLinkTest

#3474731 - f9d146518b2152cf66d9c257c1497ce03dbe6d20

One extra PHPUnit deprecation solved.

#3475024: Method getMockForAbstractClass() is deprecated - replace in class ViewsLocalTaskTest

#3475024 - 802d56e8217568e677eb312faabc93cd37ba65be

Fixes one more PHPUnit related deprecation.

#3444257: ResourceObjectNormalizer::getNormalization can result in max-age drift when different sets of fields are requested

#3444257 - 9bfcb369d3fc4cf36693baab3b498bb4ee8b1e94

Fixes a jsonapi normalization problem caused by cache being set at incorrect values.

Quite a puzzle that has been solved here 👍

#3247205: MigrateDestinationInterface::rollback() should document that its $destination_identifier parameter is an associative array

#3247205 - 4edd2db688a4a6f8ec026b6f8a38a5a2ce12db92

Improves MigrateDestinationInterface::rollback() documentation block.

#2560237: UpdatePathTestBase saves the root user before updates have run

#2560237 - 8b53ceb644e39f405cba2bf08622eedc85b1c38c

Tweaks the UpdatePathTestBase to skip a entity save and instead use direct database changes.

#3478331: Upgrade composer to 2.8.1 for PHP 8.4

#3478331 - 5c8b515c1e34c5ddef2d0494d29932e9887006cb

Bumps composer version to 2.8.1 to get PHP 8.4 compatibility.

#3463875: Ensure uniqueBundleId is unique in LoadJS

#3463875 - d44fb628e453c5de6aecb353e5866187d8d52766

Makes big pipe more resilient to an edge case making its use of loadjs JavaScript library more error-proof.

Annex

Meta

• Commits: 10
• Approach:
  • Direct commit: 0
  • Merge request + Patch: 4
  • Merge request: 6
  • Patch: 0
• Shortest running issue: 5 days
• Longest running issue: 9 years
• People: 31
• Volunteers: 14
• Organizations: 24
  • Acquia
    • phenaproxima
    • tim.plunkett
    • xjm
  • Acro Commerce
    • alexpott
  • CI&T
    • beatrizrodrigues
  • Chapter Three
    • alexpott
  • Digital Polygon
    • godotislate
  • Factorial GmbH
    • joachim
  • Full Fat Things
    • longwave
  • ImageX
    • b_sharpe
  • Jay Beaton Consulting LLC
    • jrb
  • Kanopi Studios
    • thejimbirch
  • Mobomo
    • smustgrave
  • OpenSense Labs
    • _utsavsharma
  • Phase2
    • jhedstrom
  • PreviousNext
    • acbramley
    • larowlan
    • mstrelan
    • quietone
  • Pronovix
    • mxr576
  • SWIS
    • bbrala
    • casey
  • Service NSW
    • enyug
  • Skilld
    • andypost
  • Specbee
    • ankithashetty
  • Third and Grove
    • catch
  • Thunder
    • alexpott
  • Très Bien Tech
    • nod_
  • Valuebound
    • neelam_wadhwani
  • Volunteers
    • andypost
    • ankithashetty
    • bbrala
    • bhanu951
    • enyug
    • joachim
    • jungle
    • larowlan
    • longwave
    • mondrake
    • mxr576
    • nod_
    • oknate
    • quietone
• Maintainers accepting changes
  • Alex Pott
  • Dave Long
  • catch
  • nod_
• Tags
  • vendor (3)
  • tests (2)
  • PHPUnit 11 (2)
  • PHPUnit 10 (2)
  • documentation (2)
  • Bug Smash Initiative (2)
  • ux (1)
  • Starshot blocker (1)
  • Recipes initiative (1)
  • PHP 8.4 (1)
  • Needs Review Queue Initiative (1)
  • JavaScript (1)
  • javascript (1)
  • Documentation (1)
  • configuration (1)
  • cache (1)
  • release notes (0)
  • release notes (0)

The set

$ git log --oneline --reverse --since=2024-10-07T23:59:59+00:00 --until=2024-10-09T00:00:00+00:00
d44fb628e4 Issue #3463875 by spokje, jrb, godotislate, smustgrave: Ensure uniqueBundleId is unique in LoadJS
5c8b515c1e Issue #3478331 by andypost, smustgrave: Upgrade composer to 2.8.1 for PHP 8.4
8b53ceb644 Issue #2560237 by bhanu951, smustgrave, _utsavsharma, ankithashetty, alexpott, larowlan, catch, jhedstrom: UpdatePathTestBase saves the root user before updates have run
4edd2db688 Issue #3247205 by beatrizrodrigues, quietone, joachim: MigrateDestinationInterface::rollback() should document that its $destination_identifier parameter is an associative array
9bfcb369d3 Issue #3444257 by bbrala, mxr576, quietone, acbramley, larowlan, casey, enyug, mstrelan, nick_schuch: ResourceObjectNormalizer::getNormalization can result in max-age drift when different sets of fields are requested
802d56e821 Issue #3475024 by mondrake: Method getMockForAbstractClass() is deprecated - replace in class ViewsLocalTaskTest
f9d146518b Issue #3474731 by mondrake: Method getMockForAbstractClass() is deprecated - replace in class EntityLinkTest
81f055eb1c Issue #3477329 by phenaproxima, thejimbirch, b_sharpe: Recipe validation should always treat required modules as installed
ce398e8693 Issue #3473203 by mstrelan: Fix use of ConstraintViolation instead of ConstraintViolationInterface in CKEditor5 tests
4e9a602833 Issue #3083507 by oknate, jungle, quietone, neelam_wadhwani, longwave, xjm, tim.plunkett, smustgrave: Standardize "plugin ID" in doc comments instead of "plugin_id"

$ git diff --shortstat d44fb628e4~1..4e9a602833
 185 files changed, 586 insertions(+), 397 deletions(-)