2023-07-19
A report out of time, that targets a bit older commits, till 2023-06-22.
This week is special, around ddd23, so I may arrive to the current state soonish. Now, crossing fingers really hard!
It covers commits added over the
570710ad7bcdd4fd342f9384d353b99f9dd290f7..e0d038f582d340cb8dcac7d5dbce9300b86878dc
interval on 11.x branch.
An extra client improvement for the machine name generation on the client side, to make it again more responsive. Again, as the exact previous commit, this is really impacting drupal UI users. Nice!
Another nice extra bug fix for the UI, this time on the path alias. On the specific case when there are multiple aliases only different slightly at the end, it is useful to see its full URL alias instead of a truncated version of it.
One less race condition on a test case means less random failures on testing across all issue testing :+1:
A new condition plugin based on the HTTP response code. In this was now blocks can use it to be shown even on non 200 responses.
It was later reverted a837b3c6bcbd93c8776f731b985bdf24dcbef552.
An extra race condition fix for a test that was producing a random failure, this time on ckeditor media integration test.
Bug fix on a form array declaration.
Clarifies the display of URL aliases, so it is more clear where are they pointing. Complements #3351638.
A bug fix for the info YAML files parsing to remove the dev suffix on the versions extracted, so it supports more cases.
One more race condition fix on a test case, this time in one functional JavaScript test.
Bug fix on the use of the Drupal ajax library not being declared as dependency on the internal drupal ckeditor5 library.
A improvement to include external URLs on single directory components, so they are not detected as relative, when libraries are overridden.
More helpers to make the ckeditor 4 to 5 transition a bit easier, recognizing the codesnippet plugin syntax.
Improves the validation of the media attachments multiple items widget, so it provides more accurate information for the end user when it exceeds the limit.
One extra deprecation at menu link content form, so the unused language manager argument is not anymore there in the next version.
An UI improvement for translations, like entity bundle details.
Uses a proper link on help topic contact settings.
Bug fix to use the right path on menu UI search.
Removes outdated TODO’s. Keeping the code clean is nice.
A follow-up of #3351236, to solve a phpstan lint.
A new core service, callable_resolver, to make more
consistent the way callables are resolved.
A class name typo fix!
Extra test coverage for help topics module.
In the context of #638078 and originally added at #3346765 to later being added independently, a new dependency is being added to use OpenTelemetry, through its php sdk.
Currently is not yet used, and the plan is not quite clear yet, but this may help improve performance testing, and also get some data to better take decisions around the development process.
The initial commit needed a follow-up to fix sub-tree splits.
In the context of #3354382,
more transformations to make mode phpunit data providers static were
added, this time at
Drupal\Tests\config_translation\Unit\ConfigMapperManagerTest.
phpstan linting continues to be improved.
Let me use a nice quote from the issue’s Problem/Motivation section to describe this one.
I can see no use in a body that is TRUE or FALSE, besides 42 not being a string in the first place, and think
$this->randomStringValidate(42)is a typo/auto-extend error and should have been$this->randomString(42), where it’s even debatable if 42 is needed/wanted and not a clever Hitch-hiker Guide reference.
I tracked the original addition at e59ec93f502e8e63e3b2e2006ff47f21ced19228, which is the jsonapi module addition. I looked there, and it seems that it was introduced at #2940342, via jsonapi git history 4a6f14f451bc10b098e1ccd7024f4d9ec3b80dca commit. But neither the issue nor the commit message really clarifies the doubt ;-)
Improved support for postgres, one less manual step to take if you are in 13+. Less friction, better DX.
One less random test failure, a lot more extra sanity for any contributor submitting code to the issue queue.
Moves the code implementing theme suggestions into a different method, to isolate it a bit, and maybe later refactor at #2954402.
An extra deprecation passing through the right channels, so it is discoverable for consumers. DX improves with each of these changes.
Change to remove a duplicate color and actually use another in one of the cases in claro. Attention to detail FTW
Wow, that was a big set! That is quite healthy.
I was a bit surprised by the telemetry effort, and I see transparency on the process, so it will likely be smooth when the actual use starts.
$ git log --oneline --reverse 570710ad7bcdd4fd342f9384d353b99f9dd290f7..e0d038f582d340cb8dcac7d5dbce9300b86878dc
947e0790ec Issue #3367420 by lauriii, smustgrave: Generate machine names even faster
9daaabee1e Issue #3351638 by swirt, lauriii, larowlan, mgifford, bnjmnm, smustgrave, maggiewachs: Remove truncation of path alias
c1677724b3 Issue #3317378 by Spokje, Wim Leers: [random test failure] DrupalTestsmedia_libraryFunctionalJavascriptWidgetViewsTest::testWidgetViews random fail
ad4db277b3 Issue #2245767 by John Pitcairn, andrewmacpherson, danflanagan8, leymannx, tim.plunkett, mpolishchuck, tobiasb, olli, dawehner, Anas_maw, SpadXIII, _utsavsharma, ankithashetty, jidrone, ameymudras, Daniel Korte, SimeonKesmev, Qusai Taha, jyotimishra-developer, alexpott, geek-merlin, smustgrave, DuaelFr, catch, Gábor Hojtsy, quietone, lauriii, ckrina: Allow blocks to be configured to show/hide on 200/403/404 response pages
8053a61b67 Issue #3367433 by Spokje: [random test failure] \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode random fail
3641445899 Issue #3367651 by Ahmad Smhan, MakerTimSWIS: Attached Library set to string instead of array
894c118106 Issue #3362007 by swirt, rpayanm: Make system path column more accurate
a837b3c6bc Revert "Issue #2245767 by John Pitcairn, andrewmacpherson, danflanagan8, leymannx, tim.plunkett, mpolishchuck, tobiasb, olli, dawehner, Anas_maw, SpadXIII, _utsavsharma, ankithashetty, jidrone, ameymudras, Daniel Korte, SimeonKesmev, Qusai Taha, jyotimishra-developer, alexpott, geek-merlin, smustgrave, DuaelFr, catch, Gábor Hojtsy, quietone, lauriii, ckrina: Allow blocks to be configured to show/hide on 200/403/404 response pages"
a1334300da Issue #3365970 by andypost, Spokje, dww: Fix minor version parsing in InfoParserUnitTest.php
3eb1472ba0 Issue #3350973 by Spokje, acbramley: [random failure] Curl error thrown for http in JSWebAssertTest
9c505099c7 Issue #3367204 by JeroenT, smustgrave, neclimdul: [CKEditor5] Missing dependency on drupal.ajax
575c533130 Issue #3357382 by Robert Ngo, e0ipso, smustgrave: Unable to override library auto-definition to add external CSS & JS
dd9c718324 Issue #3356929 by Wim Leers, kevinquillen: Provide an upgrade path from "codesnippet" contrib CKEditor 4 plugin to "CodeBlock" core CKEditor 5 plugin
ae4b7247b8 Issue #3059955 by oknate, Hardik_Patel_12, paulocs, phenaproxima, seanB, NikolaAt, smustgrave, bnjmnm, yogeshmpawar, rensingh99, xjm, chr.fritsch, lauriii, raman.b, Wim Leers, nikunj.shah, AndySipple, harshitthakore, saurabh.tripathi.cs, AaronMcHale, irene_dobbs, alexpott, andrewmacpherson, dorficus, effulgentsia, himanshu_sindhwani, codersukanta, pankaj.singh, tripurari, snehalgaikwad, priyanka.sahni: It is possible to overflow the number of items allowed in Media Library
d704aa3827 Issue #3325175 by Spokje, mondrake, andypost, xjm: Deprecate calling \Drupal\menu_link_content\Form\MenuLinkContentForm::_construct() with the $language_manager argument
d3a1923f6d Issue #3366676 by lauriii, smustgrave, narendraR: Display config translation forms in a modal dialog
cb90dcce1b Issue #3358575 by Amber Himes Matz, Rassoni, sourabhjain, smustgrave, andypost: Update topic contact.setting_default to use route instead of "/contact"
b9b388eeb7 Issue #2665608 by DanielVeza, AndreyMaximov, recrit, mohit_aghera: Menu UI searches links by incorrect uri
e9ae88f8b8 Issue #3361627 by Spokje, borisson_: Remove outdated @todo's in layout_builder pointing to #3018782
7e4ecad537 Issue #3354063 by Spokje, longwave, mondrake, Gauravvvv, joachim: Fix missing call to parent::setUp() in remaining tests
c4cf5949ca Issue #2982949 by kim.pepper, Sam152, andypost, FatherShawn, elber, joachim, larowlan, alexpott, catch, DieterHolvoet, tim.plunkett: Introduce CallableResolver to help standardise the DX and error handling for callbacks across various subsystems
61c851c38f Issue #3368423 by andypost: Fix namespace in NoJavaScriptAnonymousTest
c42d65e4a7 Issue #3219923 by andypost, Amber Himes Matz, jhodgdon: Add tests to enforce correct use of help_topic_link and help_route_link functions
faef0c760d Issue #3352389 by catch, smustgrave, xjm, heddn: Add open-telemetry/sdk and open-telemetry/exporter-otlp as dev dependencies
0ed2aa1ace Issue #3365331 by mondrake: [PHPUnit 10] Provide a static alternative to ConfigMapperManagerTest::providerTestHasTranslatable
95c061fa9c Issue #3358890 by Spokje, mondrake, smustgrave: Fix PHPStan L1 errors "Class \Foo\Bar not found."
cc97afe40d Issue #3359048 by Spokje, smustgrave: Fix PHPStan L1 errors "Cannot unset offset 'foo' on array<int, string>."
67bad1b36c Issue #3359179 by Spokje: Fix PHPStan L1 errors "@coversDefaultClass defined on class method foo."
ad0ffae266 Issue #3358375 by Spokje, mondrake: Fix incorrect usage of randomStringValidate in \Drupal\Tests\jsonapi\Kernel\Normalizer\JsonApiDocumentTopLevelNormalizerTest::setUp
c9412349f8 Issue #3349973 by Akram Khan, Arantxio, m.stenta, daffie, poker10, hestenet, quietone, wotnak: Automatically install pg_trgm extension on PostgreSQL 13+
1b06a82389 Issue #3352389 followup by catch: Add open-telemetry/sdk and open-telemetry/exporter-otlp as dev dependencies
61edc1b137 Issue #2980750 by Spokje, Krzysztof Domański, tacituseu: [random test failure] Random failure in CommentStatisticsTest
d21fd5d28e Issue #2953921 by andypost, donquixote, borisson_, effulgentsia: Refactor out theme hook suggestion building from ThemeManager::render() into a separate function
c3a57ec48b Issue #3358437 by Spokje, mondrake: Deprecate directly accessing ::$randomGenerator property in base test classes
e0d038f582 Issue #3339559 by Santosh_Verma, Gauravvvv: Claro: Update claro color variables
$ git diff --shortstat 570710ad7bcdd4fd342f9384d353b99f9dd290f7..e0d038f582d340cb8dcac7d5dbce9300b86878dc
72 files changed, 2045 insertions(+), 421 deletions(-)