2023-06-17
This is quite a big recap :sweat_smile:
It covers commits added over the 23fc2b6c35..570710ad7b
interval on 11.x branch.
Drupal and Symfony magic working together to improve developer experience and less lines to add on service definitions. More information on the change record.
An extract below!
--- a/core/core.services.yml
+++ b/core/core.services.yml
@@ -60,6 +60,8 @@ parameters:
queue.config:
suspendMaximumWait: 30.0
services:
+ _defaults:
+ autoconfigure: true
# Simple cache contexts, directly derived from the request context.
cache_context.ip:
class: Drupal\Core\Cache\Context\IpCacheContext
--- a/core/lib/Drupal/Core/CoreServiceProvider.php
+++ b/core/lib/Drupal/Core/CoreServiceProvider.php
@@ -97,6 +98,8 @@ public function register(ContainerBuilder $container) {
$container->addCompilerPass(new DeprecatedServicePass());
+ $container->registerForAutoconfiguration(EventSubscriberInterface::class)
+ ->addTag('event_subscriber');
}
/**
--- a/core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php
+++ b/core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php
@@ -36,6 +36,7 @@ class YamlFileLoader
'public' => 'public',
'tags' => 'tags',
'autowire' => 'autowire',
+ 'autoconfigure' => 'autoconfigure',
];
/**
@@ -254,6 +255,9 @@ private function parseDefinition(string $id, $service, string $file, array $defa
if (isset($defaults['autowire'])) {
$definition->setAutowired($defaults['autowire']);
}
+ if (isset($defaults['autoconfigure'])) {
+ $definition->setAutoconfigured($defaults['autoconfigure']);
+ }
$definition->setChanges([]);More love for single directory components, this time about YAML parsing.
Random test failures are just painful when you run into them. This change work-around most of the problem with the changed test, but as mentioned on the issue it may be an actual upstream bug.
One less regression / on media library. These kind changes impact editors positively, and make them happy :+1:
A decade over a codebase is not bad user_role_names()!
And user_roles(), it has been 22 years for you! And even
some more with BC compatibility period.
A couple of new deprecated functions, and interestingly its use has been mainly replaced with a more functional approach.
Clean up removing last remains of laminas zend framework bridge dependency, removed a couple of years ago, at #3238201.
Depending on projects like ckeditor is great to get a lot of functionality, and from time to time there may be some glitches. This is one of those, that was fixed now upstream, and related test cases could now be re-enabled.
It may be that line ending variations among different operating systems will never stop needing to have some special attention.
The good thing is that this time, at least on the Drupal side, a work-around is being removed, following a change on PHP, around line endings for email headers.
The actual change on PHP is nicely small, and it is about following the actual mail standard. And that php commit message conveys clearly the message :-)
Fix #47983: mixed LF and CRLF line endings in mail()
Email headers are supposed to be separated with CRLF. Period.
Added documentation for a hook added as part of the original condition plugin system :+1:
More power on query parameters for views, now nested values are OK.
The change is nicely clean, using NestedArray to handle
the main change.
Quite nice API addition, per original issue description, it helps to override the access in a more natural way, that was living in two different places, by adding a decorator.
This is also a nice developer experience improvement, thanks!
This is a nice developer experience improvement change too. If you ever wanted to override status messages, this may simplify your code.
Makes a Drupal a bit more compatible with 8.2.
The related [PHP RFC: Add true type][php-rfc-true-type] is an interesting read. More consistency to the PHP language is still being added.
More symfony auto-wiring support. The related follow-up at #3295751 has a set of changes that exemplify how this could help.
One less random test failure to worry about, so grateful to see those tackled. They impact everyone relying on testbot results.
Polishing existing test, and making it more efficient. Every improvement there reflects in the future test runs with lower resources and time to execute the set :+1:
Improved forward proxy support on media oembed. Interestingly originally reported as security issue, possibly for a likely DoS for valid oembeds.
This is quite interesting, the initial added changes on the issue were a bit more general, and later the scope was reduced, but it adds the basis for performance testing in core!
For now, it collects number of CSS and JavaScript files loaded, but via chrome through mink, but more are planned on different issues. A good starting point to look around this topic may be #638078.
Bug fix in ckeditor style plugin :+1:
Bug fix to avoid clearing unneeded cache bins for this cache back-end. Drupal getting faster here :+1:
This is part of a series to make migration import updates more accurate, by not changing the changed time stamp on entities. Temporally reverted and then re-added with an extra fix. More information on related issues. Consistency++
PHP GD library has support for WebP since 7.0.10. Drupal
core gd ImageToolkit plugin using that library support WebP
since d829a0e5c6edae7fc13438a39e44ca0915b8677e.
This change adds default configuration on the standard profile to by default allow webp extension on multiple places.
Lauri has transitioned from being a Drupal Core Frontend Framework Manager to a Product Manager now. Congrats!
Drupal has extensions that can be modules, profiles, and themes. This change converts the database drivers into another possible extension.
This change seems to unify more the approach, reducing special cases to handle databases, that sounds great!
More information on the related change record
Quite nice administration improvement, a new link to find permissions on roles.
Consistency fix on block_content.block_edit contextual
link.
An administration improvement around view modes UI, smoother site builder experience as a result :+1:
Improvement for the recently added announcements experimental module, so there is a route outside the toolbar.
Improvement over tests, for a more consistent approach.
PHPCS scanning, for the one engine file in core around twig.
DX improvement via documentation fix :+1:
Removes documentation pointing to no longer relevant issue.
Another nice administration UX improvement! I have hit this problem when creating content models, and it is sooo nice to see it addressed, thanks!
New JavaScript dependencies are added in the process, so the machine generated name is generated asynchronously and using the transliteration library.
This has been quite a big set, and I am glad to see so much and nice activity on core. It just took a couple of iterations to finish the notes :sweat_smile:
$ git log --oneline --reverse 23fc2b6c35..570710ad7b
553666589a Issue #3221128 by longwave, duadua, bradjones1, andypost, smustgrave: Enable service autoconfiguration for core event subscribers
80174a6c80 Issue #3365480 by ctrlADel, e0ipso, sharkbaitdc, smustgrave, sarahjean, carolpettirossi: [SDC] Improve error handling during prop validation errors
3b6179f198 Issue #3332456 by Spokje, jastraat: [random test failure] MediaTest::testLinkManualDecorator()
d5740e4ba1 Issue #3366287 by lauriii, catch, dmurphy1: [regression] Inserting media via the media library modal when paged redirects to the wrong destination
26e376b1df Issue #3348093 by andypost, murilohp, elber, Ranjit1032002, ameymudras, smustgrave, alexpott, catch: Deprecate user_roles() and user_role_names()
16d3fc11e0 Issue #3366314 by Prem Suthar, larowlan: Remove composer optimisations for laminas/laminas-zendframework-bridge
d838d8c084 Issue #3366633 by Spokje: Uncomment assertions in StyleTest related to https://github.com/ckeditor/ckeditor5/issues/11709
915fe89875 Issue #3270647 by P44T, AndyF, Sander Edwards van Muijen, Nitin shrivastava, Albert Volkman, mr.baileys, jshimota01, catch, mpellegrin, poker10, alexpott: PhpMail : broken mail headers in PHP 8.0+ because of LF characters
f0a4f3f159 Issue #3319184 by royalpinto007, bbombachini, sourabhjain, Rassoni, smustgrave, Chi, catch, mstrelan: hook_condition_info_alter is not documented
471c0afd6e Issue #3027705 by claudiu.cristea, Pancho, smustgrave: Allow ?edit[field_xyz] as query parameter in contextual filter
085ae2c2fb Issue #3347873 by kristiaanvandeneynde, BramDriesen, smustgrave, Kingdutch, quietone, borisson_: Centralize permission checks in a service
fdf05ab0de Issue #3346560 by DieterHolvoet, smustgrave: Allow extending StatusMessages class
99c902a24f Issue #3366288 by andypost, longwave: Add [#\ReturnTypeWillChange] attribute to TemporaryArrayObjectThrowingExceptions for PHP 8.3 compatibility
b83467eabc Issue #3325557 by longwave, mondrake, kim.pepper: Enable more service autowiring by adding interface aliases to core modules
cd8430a3a6 Issue #3366081 by Spokje: [random test failure] MediaTest:: testEditableCaption()
b1dd9f7e2f Issue #3355122 by joachim, dww, D34dMan: ContentTranslationContextualLinksTest should use API calls to set up translation
ca17d0acb3 Issue #3366481 by cilefen, acbramley, phenaproxima, seanB: OEmbedIframeController returns an HTTP response code that can be cached by forward proxies when it is given illegal parameters
2fc7e23e4a Issue #3346765 by catch, heddn, Akram Khan, Wim Leers, mondrake: Add PerformanceTestBase for allowing browser performance assertions within FunctionalJavaScriptTests
fc024f3520 Issue #3309585 by Mingsong, Wim Leers, Chi: CKEditor 5 Style plugin configuration tab does not appear
0448b4bcc7 Issue #3334489 by catch, Berdir, longwave, andypost: ChainedFastBackend invalidates all items when cache tags are invalidated
68c1000f77 Issue #3052115 by huzooka, HitchShock, floydm, ranjith_kumar_k_u, Sam152, edysmp, codebymikey, herved, Wim Leers, quietone, hchonov, Berdir, DamienMcKenna, rclemings, donquixote, benjifisher, fengtan, jwilson3: Mark an entity as 'syncing' during a migration update
a87a72fa06 Issue #3275557 by andypost, catch, heddn: Add webp image conversion to core's install profile's image style
412f414dc7 Revert "Issue #3052115 by huzooka, HitchShock, floydm, ranjith_kumar_k_u, Sam152, edysmp, codebymikey, herved, Wim Leers, quietone, hchonov, Berdir, DamienMcKenna, rclemings, donquixote, benjifisher, fengtan, jwilson3: Mark an entity as 'syncing' during a migration update"
d785011603 Issue #3366722 by Gábor Hojtsy, lauriii: Add Lauri Eskola to Drupal core product managers
6c1e7b0774 Issue #3256642 by mondrake, daffie, yogeshmpawar, alexpott, tmaiochi, quietone, larowlan, catch: Introduce database driver extensions and autoload database drivers' dependencies
80aa96f173 Issue #3355403 by mglaman: Add "Edit permisisons" as local task on role edit form
f87821dd0a Issue #3129669 by smustgrave, larowlan, S3b0uN3t: Block content set contextual edit links to edit_form route instead of canonical
e0cbbca62e Issue #3052115 by huzooka, HitchShock, floydm, ranjith_kumar_k_u, Sam152, edysmp, codebymikey, herved, Wim Leers, quietone, hchonov, Berdir, DamienMcKenna, rclemings, donquixote, benjifisher, fengtan, jwilson3: Mark an entity as 'syncing' during a migration update
381c38a927 Issue #3359240 by Utkarsh_33, narendraR, deviantintegral, lauriii, tim.plunkett, smustgrave, joachim, ckrina, hooroomoo: Enable bundle selection when a new view mode is created
8b92bea8c7 Issue #3356515 by fjgarlin, varun verma, smustgrave: Give users a way to access announcements if toolbar module is disabled
224543f183 Issue #3351886 by Arantxio, daffie, mondrake, longwave: Change SchemaUniquePrefixedKeysIndexTest to extend DriverSpecificDatabaseTestBase
0a6ff2635d Issue #3261574 by quietone, kkalashnikov, alexpott, smustgrave: Add .engine to files scanned by PHPCS
8b85a04407 Issue #3360139 by bradjones1: Phpdoc for ResourceTypeRepositoryInterface::get return value is incomplete
b7c4aaf2e0 Issue #3361465 by Spokje: Remove outdated @todo's pointing to #3135457
570710ad7b Issue #2662330 by Utkarsh_33, lauriii, hooroomoo, bnjmnm, tim.plunkett, Alan D., smustgrave, catch, mrweiner: Machine name generation is way too slow
$ git diff --shortstat 23fc2b6c35..570710ad7b
206 files changed, 3087 insertions(+), 591 deletions(-)